Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(macos): close menu when dropping NsMenuRef, close #129, #173 #200

Merged
merged 2 commits into from
May 27, 2024
Merged

fix(macos): close menu when dropping NsMenuRef, close #129, #173 #200

merged 2 commits into from
May 27, 2024

Conversation

pewsheen
Copy link
Contributor

@pewsheen pewsheen commented May 27, 2024 •
edited
Loading

Ref: #129, #173

@pewsheen pewsheen requested a review from amrbashir May 27, 2024 07:11
@pewsheen pewsheen changed the title fix(macos): close menu when dropping NsMenuRef, close #173 fix(macos): close menu when dropping NsMenuRef, close #129, #173 May 27, 2024
@amrbashir amrbashir linked an issue May 27, 2024 that may be closed by this pull request
[bug] Tauri crashes when clicking on menu item that belongs to replaced system tray menu #173
Closed
@amrbashir amrbashir merged commit 20ea54b into dev May 27, 2024
8 checks passed
@amrbashir amrbashir deleted the fix/close-before-release branch May 27, 2024 16:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@amrbashir amrbashir amrbashir approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[bug] Tauri crashes when clicking on menu item that belongs to replaced system tray menu
2 participants
@pewsheen @amrbashir